Browse Source

Remove the additional pin variable in Servo.cpp

as sugested by @c-born
inhttps://github.com/MarlinFirmware/Marlin/issues/1885#issuecomment-92618240
pull/1/head
AnHardt 10 years ago
committed by Richard Wackerbarth
parent
commit
8504992e9f
  1. 5
      Marlin/servo.cpp
  2. 4
      Marlin/servo.h

5
Marlin/servo.cpp

@ -244,9 +244,8 @@ uint8_t Servo::attach(int pin) {
uint8_t Servo::attach(int pin, int min, int max) {
if (this->servoIndex < MAX_SERVOS ) {
#if defined(ENABLE_AUTO_BED_LEVELING) && (PROBE_SERVO_DEACTIVATION_DELAY > 0)
if (pin > 0) this->pin = pin; else pin = this->pin;
#endif
if(pin == 0)
pin = servos[this->servoIndex].Pin.nbr;
pinMode(pin, OUTPUT); // set servo pin to output
servos[this->servoIndex].Pin.nbr = pin;
// todo min/max check: abs(min - MIN_PULSE_WIDTH) /4 < 128

4
Marlin/servo.h

@ -128,9 +128,7 @@ class Servo {
int read(); // returns current pulse width as an angle between 0 and 180 degrees
int readMicroseconds(); // returns current pulse width in microseconds for this servo (was read_us() in first release)
bool attached(); // return true if this servo is attached, otherwise false
#if defined(ENABLE_AUTO_BED_LEVELING) && PROBE_SERVO_DEACTIVATION_DELAY > 0
int pin; // store the hardware pin of the servo
#endif
private:
uint8_t servoIndex; // index into the channel data for this servo
int8_t min; // minimum is this value times 4 added to MIN_PULSE_WIDTH

Loading…
Cancel
Save