Board-based LCD delays

Marlin/src/pins/pins.h

@@ -1165,4 +1165,20 @@
   #define Z3_MS3_PIN -1
 #endif
 
+#if HAS_GRAPHICAL_LCD
+  #if !defined(ST7920_DELAY_1) && defined(BOARD_ST7920_DELAY_1)
+    #define ST7920_DELAY_1 BOARD_ST7920_DELAY_1
+  #endif
+  #if !defined(ST7920_DELAY_2) && defined(BOARD_ST7920_DELAY_2)
+    #define ST7920_DELAY_2 BOARD_ST7920_DELAY_2
+  #endif
+  #if !defined(ST7920_DELAY_3) && defined(BOARD_ST7920_DELAY_3)
+    #define ST7920_DELAY_3 BOARD_ST7920_DELAY_3
+  #endif
+#else
+  #undef ST7920_DELAY_1
+  #undef ST7920_DELAY_2
+  #undef ST7920_DELAY_3
+#endif
+
 #undef HAS_FREE_AUX2_PINS

Marlin/src/pins/sanguino/pins_ANET_10.h

@@ -175,15 +175,9 @@
     #define BTN_EN1          11
     #define BTN_EN2          10
     #define BTN_ENC          16
-    #ifndef ST7920_DELAY_1
+    #define BOARD_ST7920_DELAY_1 DELAY_NS(0)
-      #define ST7920_DELAY_1 DELAY_NS(0)
+    #define BOARD_ST7920_DELAY_2 DELAY_NS(63)
-    #endif
+    #define BOARD_ST7920_DELAY_3 DELAY_NS(125)
-    #ifndef ST7920_DELAY_2
-      #define ST7920_DELAY_2 DELAY_NS(63)
-    #endif
-    #ifndef ST7920_DELAY_3
-      #define ST7920_DELAY_3 DELAY_NS(125)
-    #endif
     #define STD_ENCODER_PULSES_PER_STEP 4
     #define STD_ENCODER_STEPS_PER_MENU_ITEM 1
   #endif

Marlin/src/pins/sanguino/pins_MELZI_CREALITY.h

@@ -59,14 +59,10 @@
 #endif
 
 // Alter timing for graphical display
-#ifndef ST7920_DELAY_1
+#if HAS_GRAPHICAL_LCD
-  #define ST7920_DELAY_1 DELAY_NS(125)
+  #define BOARD_ST7920_DELAY_1 DELAY_NS(125)
-#endif
+  #define BOARD_ST7920_DELAY_2 DELAY_NS(125)
-#ifndef ST7920_DELAY_2
+  #define BOARD_ST7920_DELAY_3 DELAY_NS(125)
-  #define ST7920_DELAY_2 DELAY_NS(125)
-#endif
-#ifndef ST7920_DELAY_3
-  #define ST7920_DELAY_3 DELAY_NS(125)
 #endif
 
 #if ENABLED(MINIPANEL)

Marlin/src/pins/sanguino/pins_MELZI_MALYAN.h

@@ -44,12 +44,8 @@
 #define BTN_ENC            28
 
 // Alter timing for graphical display
-#ifndef ST7920_DELAY_1
+#if HAS_GRAPHICAL_LCD
-  #define ST7920_DELAY_1 DELAY_NS(125)
+  #define BOARD_ST7920_DELAY_1 DELAY_NS(125)
-#endif
+  #define BOARD_ST7920_DELAY_2 DELAY_NS(125)
-#ifndef ST7920_DELAY_2
+  #define BOARD_ST7920_DELAY_3 DELAY_NS(125)
-  #define ST7920_DELAY_2 DELAY_NS(125)
-#endif
-#ifndef ST7920_DELAY_3
-  #define ST7920_DELAY_3 DELAY_NS(125)
 #endif

Marlin/src/pins/sanguino/pins_MELZI_TRONXY.h

@@ -51,12 +51,8 @@
 #define BTN_EN2         11
 #define BTN_ENC         26
 
-#ifndef ST7920_DELAY_1
+#if HAS_GRAPHICAL_LCD
-  #define ST7920_DELAY_1 DELAY_NS(0)
+  #define BOARD_ST7920_DELAY_1 DELAY_NS(0)
-#endif
+  #define BOARD_ST7920_DELAY_2 DELAY_NS(125)
-#ifndef ST7920_DELAY_2
+  #define BOARD_ST7920_DELAY_3 DELAY_NS(0)
-  #define ST7920_DELAY_2 DELAY_NS(125)
-#endif
-#ifndef ST7920_DELAY_3
-  #define ST7920_DELAY_3 DELAY_NS(0)
 #endif

Marlin/src/pins/sanguino/pins_SANGUINOLOLU_11.h

@@ -235,15 +235,9 @@
     #define BTN_EN1             29
     #define BTN_EN2             30
 
-    #ifndef ST7920_DELAY_1
+    #define BOARD_ST7920_DELAY_1 DELAY_NS(0)
-      #define ST7920_DELAY_1 DELAY_NS(0)
+    #define BOARD_ST7920_DELAY_2 DELAY_NS(188)
-    #endif
+    #define BOARD_ST7920_DELAY_3 DELAY_NS(0)
-    #ifndef ST7920_DELAY_2
-      #define ST7920_DELAY_2 DELAY_NS(188)
-    #endif
-    #ifndef ST7920_DELAY_3
-      #define ST7920_DELAY_3 DELAY_NS(0)
-    #endif
 
   #elif ENABLED(ZONESTAR_LCD) // For the Tronxy Melzi boards
 

Marlin/src/pins/stm32/pins_BIGTREE_BTT002_V1.0.h

@@ -243,15 +243,9 @@
 
   // Alter timing for graphical display
   #if HAS_GRAPHICAL_LCD
-    #ifndef ST7920_DELAY_1
+    #define BOARD_ST7920_DELAY_1 DELAY_NS(96)
-      #define ST7920_DELAY_1 DELAY_NS(96)
+    #define BOARD_ST7920_DELAY_2 DELAY_NS(48)
-    #endif
+    #define BOARD_ST7920_DELAY_3 DELAY_NS(600)
-    #ifndef ST7920_DELAY_2
-      #define ST7920_DELAY_2 DELAY_NS(48)
-    #endif
-    #ifndef ST7920_DELAY_3
-      #define ST7920_DELAY_3 DELAY_NS(600)
-    #endif
   #endif
 
 #endif // HAS_SPI_LCD

Marlin/src/pins/stm32/pins_BIGTREE_SKR_MINI_V1_1.h

@@ -209,13 +209,8 @@
 #define ON_BOARD_SPI_DEVICE 1    //SPI1
 #define ONBOARD_SD_CS_PIN  PA4   // Chip select for "System" SD card
 
-#ifndef ST7920_DELAY_1
+#if HAS_GRAPHICAL_LCD
-  #define ST7920_DELAY_1 DELAY_NS(125)
+  #define BOARD_ST7920_DELAY_1 DELAY_NS(125)
+  #define BOARD_ST7920_DELAY_2 DELAY_NS(125)
+  #define BOARD_ST7920_DELAY_3 DELAY_NS(125)
 #endif
-#ifndef ST7920_DELAY_2
-  #define ST7920_DELAY_2 DELAY_NS(125)
-#endif
-#ifndef ST7920_DELAY_3
-  #define ST7920_DELAY_3 DELAY_NS(125)
-#endif
-

Marlin/src/pins/stm32/pins_BIGTREE_SKR_PRO_V1.1.h

@@ -260,15 +260,9 @@
 
   // Alter timing for graphical display
   #if HAS_GRAPHICAL_LCD
-    #ifndef ST7920_DELAY_1
+    #define BOARD_ST7920_DELAY_1 DELAY_NS(96)
-      #define ST7920_DELAY_1 DELAY_NS(96)
+    #define BOARD_ST7920_DELAY_2 DELAY_NS(48)
-    #endif
+    #define BOARD_ST7920_DELAY_3 DELAY_NS(600)
-    #ifndef ST7920_DELAY_2
-      #define ST7920_DELAY_2 DELAY_NS(48)
-    #endif
-    #ifndef ST7920_DELAY_3
-      #define ST7920_DELAY_3 DELAY_NS(600)
-    #endif
   #endif
 
 #endif // HAS_SPI_LCD

Marlin/src/pins/stm32/pins_GENERIC_STM32F4.h

@@ -183,14 +183,8 @@
 //
 // ST7920 Delays
 //
-#ifndef ST7920_DELAY_1
+#if HAS_GRAPHICAL_LCD
-  #define ST7920_DELAY_1 DELAY_NS(96)
+  #define BOARD_ST7920_DELAY_1 DELAY_NS(96)
-#endif
+  #define BOARD_ST7920_DELAY_2 DELAY_NS(48)
-
+  #define BOARD_ST7920_DELAY_3 DELAY_NS(715)
-#ifndef ST7920_DELAY_2
-  #define ST7920_DELAY_2 DELAY_NS(48)
-#endif
-
-#ifndef ST7920_DELAY_3
-  #define ST7920_DELAY_3 DELAY_NS(715)
 #endif

Marlin/src/pins/stm32/pins_GTM32_PRO_VB.h

@@ -153,14 +153,10 @@
     //#define LCD_UART_RX    PD9
   #endif
 
-  #ifndef ST7920_DELAY_1
+  #if HAS_GRAPHICAL_LCD
-    #define ST7920_DELAY_1 DELAY_NS(96)
+    #define BOARD_ST7920_DELAY_1 DELAY_NS(96)
-  #endif
+    #define BOARD_ST7920_DELAY_2 DELAY_NS(48)
-  #ifndef ST7920_DELAY_2
+    #define BOARD_ST7920_DELAY_3 DELAY_NS(715)
-    #define ST7920_DELAY_2 DELAY_NS(48)
-  #endif
-  #ifndef ST7920_DELAY_3
-    #define ST7920_DELAY_3 DELAY_NS(715)
   #endif
 
 #endif // HAS_SPI_LCD

Marlin/src/pins/stm32/pins_LERDGE_K.h

@@ -170,12 +170,8 @@
 //
 // ST7920 Delays
 //
-#ifndef ST7920_DELAY_1
+#if HAS_GRAPHICAL_LCD
-  #define ST7920_DELAY_1 DELAY_NS(96)
+  #define BOARD_ST7920_DELAY_1 DELAY_NS(96)
-#endif
+  #define BOARD_ST7920_DELAY_2 DELAY_NS(48)
-#ifndef ST7920_DELAY_2
+  #define BOARD_ST7920_DELAY_3 DELAY_NS(715)
-  #define ST7920_DELAY_2 DELAY_NS(48)
-#endif
-#ifndef ST7920_DELAY_3
-  #define ST7920_DELAY_3 DELAY_NS(715)
 #endif

Marlin/src/pins/stm32/pins_LERDGE_X.h

@@ -167,12 +167,8 @@
 //
 // ST7920 Delays
 //
-#ifndef ST7920_DELAY_1
+#if HAS_GRAPHICAL_LCD
-  #define ST7920_DELAY_1 DELAY_NS(96)
+  #define BOARD_ST7920_DELAY_1 DELAY_NS(96)
-#endif
+  #define BOARD_ST7920_DELAY_2 DELAY_NS(48)
-#ifndef ST7920_DELAY_2
+  #define BOARD_ST7920_DELAY_3 DELAY_NS(715)
-  #define ST7920_DELAY_2 DELAY_NS(48)
-#endif
-#ifndef ST7920_DELAY_3
-  #define ST7920_DELAY_3 DELAY_NS(715)
 #endif

Marlin/src/pins/stm32/pins_MKS_ROBIN_LITE.h

@@ -132,12 +132,8 @@
 #define MOSI_PIN           P1B5
 #define SS_PIN             PA15
 
-#ifndef ST7920_DELAY_1
+#if HAS_GRAPHICAL_LCD
-  #define ST7920_DELAY_1 DELAY_NS(125)
+  #define BOARD_ST7920_DELAY_1 DELAY_NS(125)
-#endif
+  #define BOARD_ST7920_DELAY_2 DELAY_NS(125)
-#ifndef ST7920_DELAY_2
+  #define BOARD_ST7920_DELAY_3 DELAY_NS(125)
-  #define ST7920_DELAY_2 DELAY_NS(125)
-#endif
-#ifndef ST7920_DELAY_3
-  #define ST7920_DELAY_3 DELAY_NS(125)
 #endif

Marlin/src/pins/teensy2/pins_PRINTRBOARD_REVF.h

@@ -247,15 +247,9 @@
     //#define MISO         23   //         13               B3                ICSP-06             EXP2-05
 
     // increase delays
-    #ifndef ST7920_DELAY_1
+    #define BOARD_ST7920_DELAY_1 DELAY_NS(313)
-      #define ST7920_DELAY_1 DELAY_NS(313)
+    #define BOARD_ST7920_DELAY_2 DELAY_NS(313)
-    #endif
+    #define BOARD_ST7920_DELAY_3 DELAY_NS(313)
-    #ifndef ST7920_DELAY_2
-      #define ST7920_DELAY_2 DELAY_NS(313)
-    #endif
-    #ifndef ST7920_DELAY_3
-      #define ST7920_DELAY_3 DELAY_NS(313)
-    #endif
 
   #else