Merge pull request 'check empty execute' (#6) from execute into master

Reviewed-on: #6

command.go

@@ -100,6 +100,10 @@ func (c *Command) With(opts ...Option) *Command {
 
 // Run run command with input and output.
 func (c *Command) Run(ctx context.Context, in input.Input, out output.Output) error {
+	if c.Execute == nil {
+		return fmt.Errorf("%w", ErrExecuteNil)
+	}
+
 	if c.Handle != nil {
 		return c.Handle(ctx, in, out, c.Execute)
 	}

command_test.go

@@ -2,6 +2,7 @@ package console_test
 
 import (
 	"context"
+	"errors"
 	"strings"
 	"sync/atomic"
 	"testing"
@@ -125,3 +126,21 @@ func TestChainHandle(t *testing.T) {
 		}
 	}
 }
+
+func TestRunEmptyExecute(t *testing.T) {
+	t.Parallel()
+
+	ctx := context.Background()
+	empty := console.Command{
+		Name: "empty",
+	}
+	in := &input.Array{
+		Map: input.Map{},
+	}
+	out := output.Stdout()
+
+	err := empty.Run(ctx, in, out)
+	if !errors.Is(err, console.ErrExecuteNil) {
+		t.Fatalf("expected: %v, got: %v ", console.ErrExecuteNil, err)
+	}
+}

error.go

@@ -0,0 +1,31 @@
+package console
+
+import (
+	"errors"
+	"fmt"
+	"strings"
+)
+
+var (
+	ErrNotFound         = errors.New("command not found")
+	ErrCommandNil       = errors.New("console: Register command is nil")
+	ErrExecuteNil       = errors.New("console: execute is nil")
+	ErrCommandDuplicate = errors.New("console: duplicate command")
+)
+
+type AlternativesError struct {
+	Alt []string
+	Err error
+}
+
+func (e AlternativesError) Error() string {
+	return fmt.Sprintf("%s, alternatives: [%s]", e.Err, strings.Join(e.Alt, ","))
+}
+
+func (e AlternativesError) Is(err error) bool {
+	return errors.Is(e.Err, err)
+}
+
+func (e AlternativesError) Unwrap() error {
+	return e.Err
+}

example/cmd/config/main.go

@@ -16,7 +16,8 @@ const (
 	AppName   = "console"
 )
 
-// FDEVS_CONSOLE_CAT=env go run cmd/config/main.go fdevs:console:arg -b tmp.
+// FDEVS_CONSOLE_CAT=env FDEVS_CONSOLE_HIDDEN=2022-09-18T23:07:49+03:00 go run cmd/config/main.go fdevs:console:arg -b tmp.
+// FDEVS_CONSOLE_CAT=env go run cmd/config/main.go fdevs:console:arg --hidden=2022-09-18T23:07:49+03:00 -b tmp.
 func main() {
 	env := config.New(Namespace, AppName, []config.Provider{
 		env.New(),

example/pkg/command/args.go

@@ -20,6 +20,7 @@ func Args() *console.Command {
 				option.String("bar", "required bar option", option.Required, option.Short('b')),
 				option.String("cat", "cat option", option.Short('c')),
 				option.Time("time", "time example"),
+				option.Time("hidden", "hidden time example", option.Hidden),
 			)
 
 			return nil
@@ -29,6 +30,7 @@ func Args() *console.Command {
 			out.Println(ctx, "bar: <info>", in.Option(ctx, "bar").String(), "</info>")
 			out.Println(ctx, "cat: <info>", in.Option(ctx, "cat").String(), "</info>")
 			out.Println(ctx, "time: <info>", in.Option(ctx, "time").Time().Format(time.RFC3339), "</info>")
+			out.Println(ctx, "hidden: <info>", in.Option(ctx, "hidden").Time().Format(time.RFC3339), "</info>")
 
 			return nil
 		},

register.go

@@ -5,7 +5,6 @@ import (
 	"fmt"
 	"regexp"
 	"sort"
-	"strings"
 	"sync"
 )
 
@@ -14,12 +13,6 @@ const (
 	CommandList = "list"
 )
 
-var (
-	ErrNotFound         = errors.New("command not found")
-	ErrCommandNil       = errors.New("console: Register command is nil")
-	ErrCommandDuplicate = errors.New("console: duplicate command")
-)
-
 //nolint:gochecknoglobals
 var (
 	commandsMu  sync.RWMutex
@@ -27,27 +20,6 @@ var (
 	findCommand = regexp.MustCompile("([^:]+|)")
 )
 
-type AlternativesError struct {
-	alt []string
-	err error
-}
-
-func (e AlternativesError) Error() string {
-	return fmt.Sprintf("%s, alternatives: [%s]", e.err, strings.Join(e.alt, ","))
-}
-
-func (e AlternativesError) Is(err error) bool {
-	return errors.Is(e.err, err)
-}
-
-func (e AlternativesError) Unwrap() error {
-	return e.err
-}
-
-func (e AlternativesError) Alternatives() []string {
-	return e.alt
-}
-
 // MustRegister register command or panic if err.
 func MustRegister(cmd *Command) {
 	if err := Register(cmd); err != nil {
@@ -134,7 +106,7 @@ func Find(name string) (*Command, error) {
 			names[i] = findCommands[i].Name
 		}
 
-		return nil, AlternativesError{alt: names, err: ErrNotFound}
+		return nil, AlternativesError{Alt: names, Err: ErrNotFound}
 	}
 
 	return nil, ErrNotFound