fix lint

.drone.yml

@@ -10,7 +10,8 @@ steps:
 - name: test 
   image: golang
   commands:
-  - go test -parallel 10 -race ./... 
+  # - go test -parallel 10 -race ./... 
+  - go test -race ./... 
 
 - name: golangci-lint
   image: golangci/golangci-lint:v1.53

.golangci.yml

@@ -43,6 +43,8 @@ linters:
       - ifshort
       - nosnakecase
 
+      - ireturn # implement provider interface
+
 issues:
   # Excluding configuration per-path, per-linter, per-text and per-source
   exclude-rules:

client.go

@@ -124,7 +124,6 @@ func (c *Client) Value(ctx context.Context, path ...string) (Value, error) {
 }
 
 func (c *Client) Watch(ctx context.Context, callback WatchCallback, path ...string) error {
-
 	for idx, prov := range c.providers {
 		provider, ok := prov.(WatchProvider)
 		if !ok {

provider/arg/provider.go

@@ -106,7 +106,7 @@ func (p *Provider) Name() string {
 	return p.name
 }
 
-func (p *Provider) Value(ctx context.Context, path ...string) (config.Value, error) {
+func (p *Provider) Value(_ context.Context, path ...string) (config.Value, error) {
 	if err := p.parse(); err != nil {
 		return nil, err
 	}
@@ -123,7 +123,11 @@ func (p *Provider) Value(ctx context.Context, path ...string) (config.Value, err
 			}
 
 			return value.Decode(func(v interface{}) error {
-				return json.Unmarshal(data, v)
+				if err := json.Unmarshal(data, v); err != nil {
+					return fmt.Errorf("unmarshal:%w", err)
+				}
+
+				return nil
 			}), nil
 		}
 	}

provider/arg/provider_test.go

@@ -58,6 +58,7 @@ func (d *Duration) UnmarshalJSON(in []byte) error {
 	if err != nil {
 		return fmt.Errorf("parse:%w", err)
 	}
+
 	d.Duration = o
 
 	return nil

provider/env/provider.go

@@ -45,7 +45,7 @@ func (p *Provider) Name() string {
 	return p.name
 }
 
-func (p *Provider) Value(ctx context.Context, path ...string) (config.Value, error) {
+func (p *Provider) Value(_ context.Context, path ...string) (config.Value, error) {
 	name := p.prefix + p.key(path...)
 	if val, ok := os.LookupEnv(name); ok {
 		return value.JString(val), nil

provider/watcher/provider.go

@@ -67,7 +67,6 @@ func (p *Provider) Watch(ctx context.Context, callback config.WatchCallback, key
 							return
 						}
 						p.logger(ctx, "callback %v:%v", key, err)
-
 					}
 					oldVar = newVar
 				}

provider/watcher/provider_test.go

@@ -2,7 +2,7 @@ package watcher_test
 
 import (
 	"context"
-	"fmt"
+	"strconv"
 	"sync"
 	"sync/atomic"
 	"testing"
@@ -14,6 +14,8 @@ import (
 	"gitoa.ru/go-4devs/config/value"
 )
 
+var _ config.Provider = (*provider)(nil)
+
 type provider struct {
 	cnt int32
 }
@@ -25,7 +27,7 @@ func (p *provider) Name() string {
 func (p *provider) Value(context.Context, ...string) (config.Value, error) {
 	p.cnt++
 
-	return value.JString(fmt.Sprint(p.cnt)), nil
+	return value.JString(strconv.Itoa(int(p.cnt))), nil
 }
 
 func TestWatcher(t *testing.T) {
@@ -57,6 +59,7 @@ func TestWatcher(t *testing.T) {
 		},
 		"tmpname",
 	)
+
 	wg.Wait()
 
 	require.NoError(t, err)

test/provider_suite.go

@@ -26,10 +26,8 @@ func Run(t *testing.T, provider config.Provider, read []Read) {
 			val, err := provider.Value(ctx, read.Key...)
 			require.NoError(t, err, read.Key)
 			read.Assert(t, val)
-
 		})
 	}
-
 }
 
 type Read struct {

value.go

@@ -8,7 +8,7 @@ type Value interface {
 	ReadValue
 	ParseValue
 	UnmarshalValue
-	IsEquals(Value) bool
+	IsEquals(in Value) bool
 }
 
 type UnmarshalValue interface {