From 90c97c818577a3d3c245c06b7f25979741a008df Mon Sep 17 00:00:00 2001 From: Scott Lahteine Date: Mon, 18 Apr 2016 19:45:55 -0700 Subject: [PATCH] Add _draw_axis_label function to reduce source --- Marlin/dogm_lcd_implementation.h | 64 +++++++------------ .../ultralcd_implementation_hitachi_HD44780.h | 61 ++++++------------ 2 files changed, 43 insertions(+), 82 deletions(-) diff --git a/Marlin/dogm_lcd_implementation.h b/Marlin/dogm_lcd_implementation.h index ee8bb88dd1..3c49ffb8e2 100644 --- a/Marlin/dogm_lcd_implementation.h +++ b/Marlin/dogm_lcd_implementation.h @@ -309,6 +309,23 @@ FORCE_INLINE void _draw_heater_status(int x, int heater) { } } +FORCE_INLINE void _draw_axis_label(AxisEnum axis, const char *pstr, bool blink) { + if (blink) + lcd_printPGM(pstr); + else { + if (!axis_homed[axis]) + lcd_printPGM(PSTR("?")); + else { + #if DISABLED(DISABLE_REDUCED_ACCURACY_WARNING) + if (!axis_known_position[axis]) + lcd_printPGM(PSTR(" ")); + else + #endif + lcd_printPGM(pstr); + } + } +} + static void lcd_implementation_status_screen() { u8g.setColorIndex(1); // black on white @@ -382,59 +399,22 @@ static void lcd_implementation_status_screen() { u8g.drawBox(0, 30, LCD_PIXEL_WIDTH, 9); #endif u8g.setColorIndex(0); // white on black + u8g.setPrintPos(2, XYZ_BASELINE); - if (blink) - lcd_printPGM(PSTR(MSG_X)); - else { - if (!axis_homed[X_AXIS]) - lcd_printPGM(PSTR("?")); - else { - #if DISABLED(DISABLE_REDUCED_ACCURACY_WARNING) - if (!axis_known_position[X_AXIS]) - lcd_printPGM(PSTR(" ")); - else - #endif - lcd_printPGM(PSTR(MSG_X)); - } - } + _draw_axis_label(X_AXIS, PSTR(MSG_X), blink); u8g.setPrintPos(10, XYZ_BASELINE); lcd_print(ftostr4sign(current_position[X_AXIS])); u8g.setPrintPos(43, XYZ_BASELINE); - if (blink) - lcd_printPGM(PSTR(MSG_Y)); - else { - if (!axis_homed[Y_AXIS]) - lcd_printPGM(PSTR("?")); - else { - #if DISABLED(DISABLE_REDUCED_ACCURACY_WARNING) - if (!axis_known_position[Y_AXIS]) - lcd_printPGM(PSTR(" ")); - else - #endif - lcd_printPGM(PSTR(MSG_Y)); - } - } + _draw_axis_label(Y_AXIS, PSTR(MSG_Y), blink); u8g.setPrintPos(51, XYZ_BASELINE); lcd_print(ftostr4sign(current_position[Y_AXIS])); u8g.setPrintPos(83, XYZ_BASELINE); - if (blink) - lcd_printPGM(PSTR(MSG_Z)); - else { - if (!axis_homed[Z_AXIS]) - lcd_printPGM(PSTR("?")); - else { - #if DISABLED(DISABLE_REDUCED_ACCURACY_WARNING) - if (!axis_known_position[Z_AXIS]) - lcd_printPGM(PSTR(" ")); - else - #endif - lcd_printPGM(PSTR(MSG_Z)); - } - } + _draw_axis_label(Z_AXIS, PSTR(MSG_Z), blink); u8g.setPrintPos(91, XYZ_BASELINE); lcd_print(ftostr32sp(current_position[Z_AXIS] + 0.00001)); + u8g.setColorIndex(1); // black on white // Feedrate diff --git a/Marlin/ultralcd_implementation_hitachi_HD44780.h b/Marlin/ultralcd_implementation_hitachi_HD44780.h index 3164f45a21..3787db01bd 100644 --- a/Marlin/ultralcd_implementation_hitachi_HD44780.h +++ b/Marlin/ultralcd_implementation_hitachi_HD44780.h @@ -569,6 +569,23 @@ unsigned lcd_print(char c) { return charset_mapper(c); } #endif // SHOW_BOOTSCREEN +FORCE_INLINE void _draw_axis_label(AxisEnum axis, const char *pstr, bool blink) { + if (blink) + lcd_printPGM(pstr); + else { + if (!axis_homed[axis]) + lcd_printPGM(PSTR("?")); + else { + #if DISABLED(DISABLE_REDUCED_ACCURACY_WARNING) + if (!axis_known_position[axis]) + lcd_printPGM(PSTR(" ")); + else + #endif + lcd_printPGM(pstr); + } + } +} + /** Possible status screens: 16x2 |000/000 B000/000| @@ -692,36 +709,12 @@ static void lcd_implementation_status_screen() { // When axis is homed but axis_known_position is false the axis letters are blinking 'X' <-> ' '. // When everything is ok you see a constant 'X'. - if (blink) - lcd_printPGM(PSTR(MSG_X)); - else { - if (!axis_homed[X_AXIS]) - lcd_printPGM(PSTR("?")); - else - #if DISABLED(DISABLE_REDUCED_ACCURACY_WARNING) - if (!axis_known_position[X_AXIS]) - lcd_printPGM(PSTR(" ")); - else - #endif - lcd_printPGM(PSTR(MSG_X)); - } - + _draw_axis_label(X_AXIS, PSTR(MSG_X), blink); lcd.print(ftostr4sign(current_position[X_AXIS])); lcd_printPGM(PSTR(" ")); - if (blink) - lcd_printPGM(PSTR(MSG_Y)); - else { - if (!axis_homed[Y_AXIS]) - lcd_printPGM(PSTR("?")); - else - #if DISABLED(DISABLE_REDUCED_ACCURACY_WARNING) - if (!axis_known_position[Y_AXIS]) - lcd_printPGM(PSTR(" ")); - else - #endif - lcd_printPGM(PSTR(MSG_Y)); - } + + _draw_axis_label(Y_AXIS, PSTR(MSG_Y), blink); lcd.print(ftostr4sign(current_position[Y_AXIS])); #endif // EXTRUDERS > 1 || TEMP_SENSOR_BED != 0 @@ -729,19 +722,7 @@ static void lcd_implementation_status_screen() { #endif // LCD_WIDTH >= 20 lcd.setCursor(LCD_WIDTH - 8, 1); - if (blink) - lcd_printPGM(PSTR(MSG_Z)); - else { - if (!axis_homed[Z_AXIS]) - lcd_printPGM(PSTR("?")); - else - #if DISABLED(DISABLE_REDUCED_ACCURACY_WARNING) - if (!axis_known_position[Z_AXIS]) - lcd_printPGM(PSTR(" ")); - else - #endif - lcd_printPGM(PSTR(MSG_Z)); - } + _draw_axis_label(Z_AXIS, PSTR(MSG_Z), blink); lcd.print(ftostr32sp(current_position[Z_AXIS] + 0.00001)); #endif // LCD_HEIGHT > 2