From 3f89bbeab546f15fb1a3eb99964b194b862fb9c1 Mon Sep 17 00:00:00 2001 From: Scott Lahteine Date: Sat, 24 Feb 2018 16:35:31 -0600 Subject: [PATCH] Drop a conditional only used once --- Marlin/src/gcode/bedlevel/abl/G29.cpp | 2 +- Marlin/src/inc/Conditionals_post.h | 5 ----- Marlin/src/module/probe.cpp | 16 ++++++++-------- 3 files changed, 9 insertions(+), 14 deletions(-) diff --git a/Marlin/src/gcode/bedlevel/abl/G29.cpp b/Marlin/src/gcode/bedlevel/abl/G29.cpp index f8e2a5826d..9285b46ed6 100644 --- a/Marlin/src/gcode/bedlevel/abl/G29.cpp +++ b/Marlin/src/gcode/bedlevel/abl/G29.cpp @@ -733,7 +733,7 @@ void GcodeSuite::G29() { #endif // AUTO_BED_LEVELING_3POINT - // Raise to _Z_CLEARANCE_DEPLOY_PROBE. Stow the probe. + // Stow the probe, raising if not fix-mounted. if (STOW_PROBE()) { set_bed_leveling_enabled(abl_should_enable); measured_z = NAN; diff --git a/Marlin/src/inc/Conditionals_post.h b/Marlin/src/inc/Conditionals_post.h index 6ea54dd427..d8c9f23a6c 100644 --- a/Marlin/src/inc/Conditionals_post.h +++ b/Marlin/src/inc/Conditionals_post.h @@ -916,11 +916,6 @@ #define XY_PROBE_SPEED 4000 #endif #endif - #if Z_CLEARANCE_BETWEEN_PROBES > Z_CLEARANCE_DEPLOY_PROBE - #define _Z_CLEARANCE_DEPLOY_PROBE Z_CLEARANCE_BETWEEN_PROBES - #else - #define _Z_CLEARANCE_DEPLOY_PROBE Z_CLEARANCE_DEPLOY_PROBE - #endif #else #undef X_PROBE_OFFSET_FROM_EXTRUDER #undef Y_PROBE_OFFSET_FROM_EXTRUDER diff --git a/Marlin/src/module/probe.cpp b/Marlin/src/module/probe.cpp index 5d90734974..0a4692a347 100644 --- a/Marlin/src/module/probe.cpp +++ b/Marlin/src/module/probe.cpp @@ -374,15 +374,15 @@ bool set_probe_deployed(const bool deploy) { if (endstops.z_probe_enabled == deploy) return false; - // Fix-mounted probe should only raise for deploy - #if ENABLED(FIX_MOUNTED_PROBE) - #define RAISE_COND deploy - #else - #define RAISE_COND true - #endif - // Make room for probe to deploy (or stow) - if (RAISE_COND) do_probe_raise(_Z_CLEARANCE_DEPLOY_PROBE); + // Fix-mounted probe should only raise for deploy + if ( + #if ENABLED(FIX_MOUNTED_PROBE) + deploy + #else + true + #endif + ) do_probe_raise(max(Z_CLEARANCE_BETWEEN_PROBES, Z_CLEARANCE_DEPLOY_PROBE)); #if ENABLED(Z_PROBE_SLED) || ENABLED(Z_PROBE_ALLEN_KEY) #if ENABLED(Z_PROBE_SLED)